feat: added Dhivehi language layout#388
Open
statenti wants to merge 3 commits intoFossifyOrg:mainfrom
Open
Conversation
naveensingh
changed the title
naveensingh
requested changes
Feb 2, 2026
Member
naveensingh
left a comment
naveensingh
left a comment
There was a problem hiding this comment.
I found some issues:
- Some of the keys have inverted default. For example, on the 2nd key in the top row,
ޢis the default instead ofއ. - The top row keys display 1, 2, etc. in the corner, but on long-press, those numbers do not exist (
0replaced with÷). The pop-up should contain both the language character + the number on long-press.
Do you speak this language yourself?
| LANGUAGE_CZECH_QWERTY -> "${getString(R.string.translation_czech)} (QWERTY)" | ||
| LANGUAGE_CZECH_QWERTZ -> "${getString(R.string.translation_czech)} (QWERTZ)" | ||
| LANGUAGE_DANISH -> getString(R.string.translation_danish) | ||
| LANGUAGE_DHIVEHI -> "Dhivehi" |
Member
There was a problem hiding this comment.
Strings shouldn't be hardcoded. Please add this to Fossify Commons lib for reusability: https://github.com/FossifyOrg/commons
Comment on lines
+83
to
+84
| const val LANGUAGE_DHIVEHI = 45 | ||
|
|
Member
There was a problem hiding this comment.
Unnecessary empty line
Suggested change
| const val LANGUAGE_DHIVEHI = 45 | |
| const val LANGUAGE_DHIVEHI = 45 |
Comment on lines
+1
to
+61
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Keyboard xmlns:app="http://schemas.android.com/apk/res-auto"> | ||
| <Row app:isNumbersRow="true"> | ||
| <Key app:keyEdgeFlags="left" app:keyLabel="1" app:topSmallNumber="1" /> | ||
| <Key app:keyLabel="2" app:topSmallNumber="2" /> | ||
| <Key app:keyLabel="3" app:topSmallNumber="3" /> | ||
| <Key app:keyLabel="4" app:topSmallNumber="4" /> | ||
| <Key app:keyLabel="5" app:topSmallNumber="5" /> | ||
| <Key app:keyLabel="6" app:topSmallNumber="6" /> | ||
| <Key app:keyLabel="7" app:topSmallNumber="7" /> | ||
| <Key app:keyLabel="8" app:topSmallNumber="8" /> | ||
| <Key app:keyLabel="9" app:topSmallNumber="9" /> | ||
| <Key app:keyEdgeFlags="right" app:keyLabel="0" app:topSmallNumber="0" /> | ||
| </Row> | ||
|
|
||
| <Row> | ||
| <Key app:keyEdgeFlags="left" app:keyLabel="ް" app:popupCharacters="ޤ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="1" /> | ||
| <Key app:keyLabel="ޢ" app:popupCharacters="އ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="2" /> | ||
| <Key app:keyLabel="ެ" app:popupCharacters="ޭ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="3" /> | ||
| <Key app:keyLabel="ރ" app:popupCharacters="ޜ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="4" /> | ||
| <Key app:keyLabel="ތ" app:popupCharacters="ޓ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="5" /> | ||
| <Key app:keyLabel="ޔ" app:popupCharacters="ޘ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="6" /> | ||
| <Key app:keyLabel="ު" app:popupCharacters="ޫ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="7" /> | ||
| <Key app:keyLabel="ި" app:popupCharacters="ީ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="8" /> | ||
| <Key app:keyLabel="ޮ" app:popupCharacters="ޯ" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="9" /> | ||
| <Key app:keyEdgeFlags="right" app:keyLabel="ޕ" app:popupCharacters="÷" app:popupKeyboard="@xml/keyboard_popup_template" app:topSmallNumber="0" /> | ||
| </Row> | ||
|
|
||
| <Row> | ||
| <Key app:horizontalGap="5%" app:keyEdgeFlags="left" app:keyLabel="ަ" app:popupCharacters="ާ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ސ" app:popupCharacters="ށ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ދ" app:popupCharacters="ޑ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ފ" app:popupCharacters="ﷲ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ގ" app:popupCharacters="ޣ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ހ" app:popupCharacters="ޙ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ޖ" app:popupCharacters="ޛ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ކ" app:popupCharacters="ޚ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyEdgeFlags="right" app:keyLabel="ލ" app:popupCharacters="ޅ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| </Row> | ||
|
|
||
| <Row> | ||
| <Key app:code="-1" app:keyEdgeFlags="left" app:keyIcon="@drawable/ic_caps_outline_vector" app:keyWidth="15%p" /> | ||
| <Key app:keyLabel="ޒ" app:popupCharacters="ޜ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ޘ" app:popupCharacters="×" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ޝ" app:popupCharacters="ޗ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ވ" /> | ||
| <Key app:keyLabel="ބ" app:popupCharacters="ޟ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="ނ" app:popupCharacters="ޏ" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:keyLabel="މ" /> | ||
| <Key app:code="-5" app:isRepeatable="true" app:keyEdgeFlags="right" app:keyIcon="@drawable/ic_clear_vector" app:keyWidth="15%p" /> | ||
| </Row> | ||
|
|
||
| <Row> | ||
| <Key app:code="-2" app:keyEdgeFlags="left" app:keyLabel="\?123" app:keyWidth="15%p" /> | ||
| <Key app:keyLabel="،" app:keyWidth="10%p" app:keyRole="tools" app:popupKeyboard="@xml/popup_tools_with_emoji_key" app:secondaryKeyIcon="@drawable/ic_emoji_emotions_outline_vector" /> | ||
| <Key app:code="-6" app:keyEdgeFlags="left" app:keyIcon="@drawable/ic_emoji_emotions_outline_vector" app:keyWidth="10%p" app:secondaryKeyIcon="@drawable/ic_language_outlined" /> | ||
| <Key app:code="32" app:isRepeatable="true" app:keyWidth="40%p" /> | ||
| <Key app:keyLabel="." app:keyWidth="10%p" app:popupCharacters="،؟!؛:'…" app:popupKeyboard="@xml/keyboard_popup_template" /> | ||
| <Key app:code="-4" app:keyEdgeFlags="right" app:keyIcon="@drawable/ic_enter_vector" app:keyWidth="15%p" /> | ||
| </Row> | ||
| </Keyboard> |
Member
There was a problem hiding this comment.
This file is unformatted. Please format it in Android Studio.
naveensingh
added
the
waiting for author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Tests performed
Tested on Pixel 6a running updated Android
Checklist